Lights come on but wont start.

[mrlmd1]

Have you checked the starter solenoid (or relay)? That's another thing that can fail. The solenoid may click with low battery voltage, or even with a good battery, but may not pass the high current through it to the starter motor. You can short out the contacts on the solenoid and see if the starter turns over. The solenoid could be bad, the contacts could be dirty. You know your starter is good and the bike runs, so all the safety switches must be fine.
So your problem is either the starter switch, starter relay, wiring somewhere in between those, or a weak battery.
You have to check everything down the line in sequence to find the bad link and not just guess on what to replace next.